Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6850/5/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 692: return base_data_->EstimateOnDiskSize() + delta_tracker_->EstimateOnDiskSize(); > since this now includes the UNDO deltas, whereas before it didn't, will thi This has no effect on compaction policy. EstimateDeltaOnDiskSize is renamed to EstimateRedoDeltaOnDiskSize, since it only counts redos, and it keeps the same implementation except it now calls EstimateRedoDeltaOnDiskSize, which is just a rename of DeltaTracker's EstimateOnDiskSize, since it only counted redo deltas. The original names are used for new functions which count undos as well as redos, so they are more properly a full on-disk size estimate, and they'll be surfaced to metrics instead of the redo-only number. Like Mike, I checked the codebase for other uses of these functions and I'm sure there's no other effects. -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
