Adar Dembo has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6874/2/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 45: using strings::Substitute; > warning: using decl 'Substitute' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/6874/2/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: Line 168: return Submit(std::shared_ptr<Runnable>(new ClosureRunnable(std::move(c)))); > warning: std::move of the const variable has no effect; remove std::move() Done Line 380: return Submit(std::shared_ptr<Runnable>(new ClosureRunnable(std::move(c)))); > warning: std::move of the const variable has no effect; remove std::move() Done http://gerrit.cloudera.org:8080/#/c/6874/2/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: Line 285: Status DoSubmit(std::shared_ptr<Runnable> task, > warning: function 'kudu::ThreadPool::DoSubmit' has a definition with differ Done -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
