Dan Burkert has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: PS3, Line 146: std::move I think you want std::forward here. http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: Line 198: DISALLOW_COPY_AND_ASSIGN(SequenceToken); I was curious about this, so I looked it up in Effective Modern C++ (page 111): > Declaring a move operation (construction or assignment) in a class causes > compilers to disable the copy operations. (The copy operations are disabled > by deleting them—see Item 11). So this should be safe to leave off. That being said, It's perfectly fine with me if you leave it. Line 220: // The execution order will be A1, T1, T2, A2, A3. What happens if A1 begins running before A2 is submitted? Won't A2 run second in that case? -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
