Adar Dembo has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 419: TEST_F(ThreadPoolTest, TestTokenSubmitsProcessedSerially) { > I think this may fail on a single CPU system. I'm not seeing why; can you elaborate? http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: PS3, Line 146: std::move > I think you want std::forward here. I can't say I understand the difference between move() and forward() (even after reading an article or two about it), but I've changed both of these moves to be forwards. http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: Line 198: DISALLOW_COPY_AND_ASSIGN(SequenceToken); > I was curious about this, so I looked it up in Effective Modern C++ (page 1 I think I will since it adds information for people who aren't familiar with that aspect of move operations. PS3, Line 203: FIFO > nit: missing "queue" Done PS3, Line 220: The execution order will be A1, T1, T2, A2, A3. > this is a _possible_ execution order, right? Dan: A2 isn't allowed to run until A1 has finished. You're right though that if A1 finishes before A2 is submitted, A2 will run second. I'll clarify that. I should have clarified that this execution order presupposes that the tasks are long-running (i.e. that A3 will be submitted before any task finishes). -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
