Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ......................................................................
Patch Set 2: (4 comments) I changed the names to - Remove the word "Estimate" because they aren't estimates. - Get rid of references to "compaction" by naming the measure by what it is, not what it is used for. The remaining *Compaction* method is MergeCompactionSize, which isn't anything sensible except for its role in compactions, so I named it after the specific kind of compaction it's used for. http://gerrit.cloudera.org:8080/#/c/6967/2/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: Line 199: uint64_t ret = 0; > This can call into the function below for this first loop Done PS2, Line 212: :EstimateCompactionSize > How about EstimateOnDiskDataSize? And then doc it as actual data stored on Done http://gerrit.cloudera.org:8080/#/c/6967/2/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: Line 71: uint64_t EstimateOnDiskSize() const; > We should doc this too Done Line 73: uint64_t EstimateCompactionSize() const; > Needs doc Done -- To view, visit http://gerrit.cloudera.org:8080/6967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32dce598bbb8e18325210a49fc436fd0f7ac68fd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
