Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/5/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: Line 115: virtual Status DebugDump(vector<string> *lines = NULL) = 0; > warning: default arguments on virtual or override methods are prohibited [g ignored http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: PS4, Line 257: rs->MergeCompactionSize() > In what way are undos not relevant? See MergeUndoHistories() in compaction. Hm, you're right about that. Based on Todd's comments on previous patches, I guess this has worked ok for a while, and changing it may have bad effects it will be very difficult to detect or measure, so we shouldn't touch it now. http://gerrit.cloudera.org:8080/#/c/6967/4/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: PS4, Line 229: on_disk_size > Yes I know it's consistent with the style guide, so that's fine. But every I'll keep it as is unless you really can't stand it. http://gerrit.cloudera.org:8080/#/c/6967/5/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: Line 230: return on_disk_size_.load(); > Looks like you need std::memory_order_relaxed here and in the .cc file Yeah :( it compiles on OS X, I guess Jenkins build is stricter about std namespace members? I've rn into similar whoopsies a couple of times with OS X v Jenkins. -- To view, visit http://gerrit.cloudera.org:8080/6967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32dce598bbb8e18325210a49fc436fd0f7ac68fd Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
