Will Berkeley has posted comments on this change.

Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric
......................................................................


Patch Set 2:

> Also, I wonder if we shouldn't introduce an additional metric which
 > would capture these additional types of disk usage. This is getting
 > into metadata territory and I think having separate metrics
 > measuring data stored and total size on disk including metadata
 > would be useful.

That's a good idea. It would make sense to have a "Tablet size on-disk" and a 
"Tablet metadata size on-disk", I think. I'll add the later into part 2 (as 
that change logically fits there).

-- 
To view, visit http://gerrit.cloudera.org:8080/6967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32dce598bbb8e18325210a49fc436fd0f7ac68fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: No

Reply via email to