Andrew Wong has posted comments on this change. Change subject: KUDU-1911 add more helpful error message when required tool arguments are missing ......................................................................
Patch Set 1: (3 comments) left a couple formatting comments http://gerrit.cloudera.org:8080/#/c/6986/1//COMMIT_MSG Commit Message: Line 7: KUDU-1911 add more helpful error message when required tool arguments are missing nit: from https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines: "As a general rule, your messages should start with a single line that’s no more than about 50 characters and that describes the changeset concisely, followed by a blank line, followed by a more detailed explanation." http://gerrit.cloudera.org:8080/#/c/6986/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 508: TEST_F(ToolTest, TestActionRequiredArgument) { maybe TestActionMissingRequiredArg? Line 510: NO_FATALS(RunActionRequiredArgument("cluster ksck --master_addresses=master.example.com", "master_addresses")); nit: keep the line length under 100 characters See this part of the style guide for spacing tips: https://google.github.io/styleguide/cppguide.html#Formatting -- To view, visit http://gerrit.cloudera.org:8080/6986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2128a01da5c4929981b2ea46a32b0f7b9dd066e1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
