Andrew Wong has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6986/3//COMMIT_MSG Commit Message: PS3, Line 11: his commit changes : the message to "must provide positional argument mi should be updated with the "variadic" change http://gerrit.cloudera.org:8080/#/c/6986/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS3, Line 226: redArgu nit: RunActionMissingRequiredArg() PS3, Line 234: :InvalidArgument( : Substitute(message, required_arg)); does this still need to line wrap? -- To view, visit http://gerrit.cloudera.org:8080/6986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2128a01da5c4929981b2ea46a32b0f7b9dd066e1 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
