Andrew Wong has posted comments on this change. Change subject: KUDU-1911 improve missing required arg message ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6986/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS4, Line 228: ide positional argument $0"; : const string kVariadicArgumentMessage = "must provide nit: it may be better for readability to move these "$0" into the call to Substitute() I.e. Substitute("$0 $1", message, required_arg) PS4, Line 515: nit: can you put a /* variadic */ here? -- To view, visit http://gerrit.cloudera.org:8080/6986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2128a01da5c4929981b2ea46a32b0f7b9dd066e1 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
