Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters ......................................................................
Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/6845/11/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 218: const string& daemon_id, ExternalDaemonOptions* opts) const; > error: unknown type name 'string'; did you mean 'std::string'? [clang-diagn Done Line 218: const string& daemon_id, ExternalDaemonOptions* opts) const; > error: unknown type name 'string'; did you mean 'std::string'? [clang-diagn Done Line 218: const string& daemon_id, ExternalDaemonOptions* opts) const; > error: unknown type name 'string'; did you mean 'std::string'? [clang-diagn Done http://gerrit.cloudera.org:8080/#/c/6845/11/src/kudu/integration-tests/multidir-cluster-itest.cc File src/kudu/integration-tests/multidir-cluster-itest.cc: Line 20: #include <string> > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
