Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/6845/15/src/kudu/integration-tests/delete_table-itest.cc File src/kudu/integration-tests/delete_table-itest.cc: Line 1063: ASSERT_OK(env_->DeleteRecursively(cluster_->master()->data_dir())); Would it make sense to just provide a DeleteFromDisk() method on the daemon? http://gerrit.cloudera.org:8080/#/c/6845/15/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 253: string data_path = "data"; I think we should add a check s.t. if dir_index is not passed then we must have only one data dir (and doc that requirement in the header file): if (!dir_index) { CHECK_EQ(1, opts_.num_data_dirs); } PS15, Line 254: if (dir_index != boost::none) not a big deal but you can just say if (dir_index) here if you want PS15, Line 255: dir_index.get() it's up to you but fyi you can also use the syntax *dir_index PS15, Line 255: CHECK CHECK_LE http://gerrit.cloudera.org:8080/#/c/6845/15/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 20: #include <boost/optional.hpp> nit: boost/optional isn't a standard C header, it should either go with the C++ stdlib includes or with the thirdparty C++ includes -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
