Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1911 improve missing required arg message ......................................................................
KUDU-1911 improve missing required arg message When using a tool that has a required positional argument, excluding that argument or passing it as a flag caused a confusing error message to be printed out ("must provide missing_argument"). This commit changes the message to "must provide positional argument missing_argument" for non-variadic arguments and "must provide variadic positional argument missing_argument" for variadic arguments. Change-Id: I2128a01da5c4929981b2ea46a32b0f7b9dd066e1 Reviewed-on: http://gerrit.cloudera.org:8080/6986 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> Reviewed-by: Dan Burkert <danburk...@apache.org> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_main.cc 2 files changed, 24 insertions(+), 2 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Andrew Wong: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2128a01da5c4929981b2ea46a32b0f7b9dd066e1 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins