Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/6967/6/src/kudu/tablet/cfile_set.h File src/kudu/tablet/cfile_set.h: PS6, Line 75: The size on-disk Do you think it's worth clarifying what 'on-disk' means? Is that the reported size of files or how many disk blocks it takes? In other words, whether that's more about the output from 'ls -l' or from 'du --block-size=1' ('du -b' or 'du --block-size=1') That's said, maybe the term 'on-disk size' is not the best one for these stats? http://gerrit.cloudera.org:8080/#/c/6967/6/src/kudu/tablet/compaction_policy-test.cc File src/kudu/tablet/compaction_policy-test.cc: PS6, Line 108: int hopefully that's not in the order of petabytes in total :) http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: PS7, Line 238: Estimate is this still an estimate? http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: PS7, Line 284: on_disk_size_.store(superblock.ByteSizeLong(), memory_order_relaxed); Maybe, it's worth doing this in LoadFromSuperBlock() instead? That way it would be automatically updated while calling ReplaceSuperBlockUnlocked() and it would not be necessary to call it in Flush() -- To view, visit http://gerrit.cloudera.org:8080/6967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32dce598bbb8e18325210a49fc436fd0f7ac68fd Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
