Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6967/7/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: PS7, Line 284: on_disk_size_.store(superblock.ByteSizeLong(), memory_order_relaxed); > Woops, you are right -- that would not work. Good catch, thanks! What you suggest works nicely. Done. -- To view, visit http://gerrit.cloudera.org:8080/6967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32dce598bbb8e18325210a49fc436fd0f7ac68fd Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
