Todd Lipcon has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: Line 105: FsManager(Env* env, std::string wal_dir, std::vector<std::string> data_dirs); why have this instead of just passing in an FsManagerOpts with the appropriate settings? http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 426: const std::string& data_dir() const { return data_dirs_[0]; } worth DCHECKing here that data_dirs_.size() == 1? seems like it might be easy for a test author to waste some time here if they made this mistake http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/integration-tests/multidir-cluster-itest.cc File src/kudu/integration-tests/multidir-cluster-itest.cc: Line 45: void MultiDirClusterITest::InsertPayload(const string& table_name, int start_row, maybe TestWorkload could do this just as well? -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
