Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement ......................................................................
Patch Set 45: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: PS44, Line 181: // 'last_logged_opid' should be set to the last opid in the log, if any is known. : // If 'last_logged > this isn't accurate anymore, is it? Done http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 247: CHECK_OK(fs_manager_->dd_manager()->CreateDataDirGroup(tablet_id_)); > should we be able to CHECK_OK this? Right DeleteTabletData should ensure this in terms of whether the tablet already exists. Could also fail if there's a disk error or if all dirs are full. This will probably change with disk failure-handling support. Line 265: CHECK(fs_manager_->dd_manager()->GetDataDirGroupPB(tablet_id_, > same, we expect this to always succeed so could CHECK right? Same Done http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: PS44, Line 186: tablet::TabletDataState delete_type, : const boost::optional<consensus::OpId>& last_logged_opid); : > not true anymore? Done -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9828147f4fa5c4d7f6ed23441dca5a116b8cb11b Gerrit-PatchSet: 45 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
