David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement ......................................................................
Patch Set 40: (3 comments) looks, just nits. http://gerrit.cloudera.org:8080/#/c/6636/40/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: PS40, Line 239: bool GetDataDirGroupPB(const std::string& tablet_id, DataDirGroupPB* pb) const; why not return Status::NotFound()? http://gerrit.cloudera.org:8080/#/c/6636/46/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: PS46, Line 388: oup c you say 1.4.0 somewhere else http://gerrit.cloudera.org:8080/#/c/6636/46/src/kudu/util/pb_util.proto File src/kudu/util/pb_util.proto: PS46, Line 45: } nit: what changed here? -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9828147f4fa5c4d7f6ed23441dca5a116b8cb11b Gerrit-PatchSet: 40 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
