Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement ......................................................................
Patch Set 44: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: PS44, Line 181: // If 'delete_type' is TABLET_DATA_COPYING, a new DataDirGroup will be generated : // for the tablet. this isn't accurate anymore, is it? http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: Line 247: fs_manager_->dd_manager()->CreateDataDirGroup(tablet_id_); should we be able to CHECK_OK this? Line 265: fs_manager_->dd_manager()->GetDataDirGroupPB(tablet_id_, superblock_->mutable_data_dir_group()); same, we expect this to always succeed so could CHECK right? http://gerrit.cloudera.org:8080/#/c/6636/44/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: PS44, Line 186: // If 'delete_type' is TABLET_DATA_COPYING, this call also creates a new data : // dir group for the existing tablet. : not true anymore? -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9828147f4fa5c4d7f6ed23441dca5a116b8cb11b Gerrit-PatchSet: 44 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
