Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager: allow runtime disabling via flag ......................................................................
maintenance_manager: allow runtime disabling via flag This should fix a flake in alter_table-test that was causing failures about 0.3% of the time when I looped it (and worse than that in the normal test environment). The issue was that this test sets FLAGS_enable_maintenance_manager to false at runtime, and then manually triggers compaction operations and asserts on the results. In commit 40aa4c3c271c9df20a1 I "fixed" the flag to only be checked at startup rather than in each iteration of the maintenance scheduler. Several other tests also set this flag to false, so it's possible this will reduce other flakiness as well. After the fix I looped alter_table-test 2000 times in ASAN with no failures. Prior to it, it failed 3/1000. Change-Id: I2207c9674fc1016253af038fc8fa8a14d2bb45a0 Reviewed-on: http://gerrit.cloudera.org:8080/7164 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/util/maintenance_manager.cc M src/kudu/util/maintenance_manager.h 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2207c9674fc1016253af038fc8fa8a14d2bb45a0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
