Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7165

to review the following change.

Change subject: external_mini_cluster: use a default destructor for options 
struct
......................................................................

external_mini_cluster: use a default destructor for options struct

If a non-default destructor is defined, then the implicit move
constructor won't be defined, and our use of std::move() when
instantiating ExternalMiniCluster causes a clang-tidy warning.

Change-Id: I66f931b9b79f4be07f33692d6a10854340a9f19d
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
2 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7165/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66f931b9b79f4be07f33692d6a10854340a9f19d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>

Reply via email to