Todd Lipcon has submitted this change and it was merged. Change subject: external_mini_cluster: use a default destructor for options struct ......................................................................
external_mini_cluster: use a default destructor for options struct If a non-default destructor is defined, then the implicit move constructor won't be defined, and our use of std::move() when instantiating ExternalMiniCluster causes a clang-tidy warning. Change-Id: I66f931b9b79f4be07f33692d6a10854340a9f19d Reviewed-on: http://gerrit.cloudera.org:8080/7165 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h 2 files changed, 0 insertions(+), 4 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f931b9b79f4be07f33692d6a10854340a9f19d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
