Adar Dembo has posted comments on this change. Change subject: server: move apply_pool into KuduServer ......................................................................
Patch Set 11: > (1 comment) > > looks good but the tests aren't happy Yeah, serves me right for reordering commits willy-nilly. The underlying issue is actually fixed by the next commit: we're shutting down the apply pool (via KuduServer::Shutdown) before we shut down the replicas themselves (via TSTabletManager::Shutdown). I'll reorder the commits. -- To view, visit http://gerrit.cloudera.org:8080/6984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7ffc886269aa6531517a52fef29c4408a925aed Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
