Todd Lipcon has posted comments on this change. Change subject: server: move apply_pool into ServerBase ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6984/10//COMMIT_MSG Commit Message: PS10, Line 11: ServerBase per comment in the parent commit, I'm not wild about putting too much Kudu-specific stuff into server/. The idea was to keep it largely independent/reusable for any distributed system server type thing (eg if we add a long running canary role, or a REST/grpc proxy role, or separate load-balancer, etc, then they could reuse server/ as is). I know though that the master and tserver have grown quite a bit of duplicate stuff around 'Tablet hosting' functionality, and this is the latest in a long line of such duplications. As much as I hate deep class hierarchies, maybe we should introduce some intermediate class here like TabletHostingServer or somesuch? Or could we move ts_tablet_manager into a different directory and make it usable by the master for hosting the catalog table, and put this stuff there? -- To view, visit http://gerrit.cloudera.org:8080/6984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7ffc886269aa6531517a52fef29c4408a925aed Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
