Todd Lipcon has submitted this change and it was merged. Change subject: server: move apply_pool into KuduServer ......................................................................
server: move apply_pool into KuduServer The server-wide apply_pool was instantiated in two places: SysCatalogTable (for the master) and TsTabletManager (for the tserver). This commit moves it into KuduServer and unifies the instantiation. Note: the apply pool semantics have not changed. Some interesting side effects: 1. The master will now generate apply pool metrics. 2. The apply pool is shut down a little bit later in server shutdown than it was before, though I don't see any issues with this. Change-Id: Ie7ffc886269aa6531517a52fef29c4408a925aed Reviewed-on: http://gerrit.cloudera.org:8080/6984 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/kserver/kserver.cc M src/kudu/kserver/kserver.h M src/kudu/master/catalog_manager.cc M src/kudu/master/sys_catalog.cc M src/kudu/master/sys_catalog.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 8 files changed, 65 insertions(+), 59 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7ffc886269aa6531517a52fef29c4408a925aed Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
