Mike Percy has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 12: Code-Review+1 (3 comments) Looks pretty good to me http://gerrit.cloudera.org:8080/#/c/6874/12/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: PS12, Line 134: m Is this different than pool_->lock_ ? Line 196: while (state() != State::QUIESCED) { Could use a comment indicating who is responsible for transitioning the token to QUIESCED. http://gerrit.cloudera.org:8080/#/c/6874/12/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: PS12, Line 410: m Would be nice to mention what 'm' is for. -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
