Todd Lipcon has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6874/11/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: Line 138: // 2. CONCURRENT: submitted tasks may be run in parallel. This isn't unlike > Suppose you have n contexts sharing a single threadpool. If tokens aren't u got it. PS11, Line 190: : // Waits for the pool to reach the idle state, or until 'delta' time elapses. : // Returns true if the pool reached the idle state, false otherwise > Er, why? It is a "new paragraph" within the NewToken() documentation, so I I meant that the whole comment block belongs with the function rather than the definition, but it's ok http://gerrit.cloudera.org:8080/#/c/6874/12/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: PS12, Line 410: m > Moot now that pool->lock is referenced directly. hm, did you forget to post the newest rev with this change? -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
