David Ribeiro Alves has posted comments on this change. Change subject: threadpool: token-based task sequencing ......................................................................
Patch Set 11: I took a look at the other patch. Todd is a better arbitrer as to correctness but in general the solution seems reasonable. I honestly would still prefer not to have to mandate that all tokens are returned to the pool (i.e. enforce that all tasks are finished and no future tasks can run, but don't force all threads hanging on to tokens to return them), from a library design perspective. This is specially problematic if we ever have more than one thread pool in which the running tasks have cyclic dependencies (i.e. tasks from a tp A submit to a tp B and vice versa). But I guess that the end goal is to have a single tp, making the point less relevant in this case. -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If46dc34212027b6ea5dbc2ead7c7af8be57f2c70 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
