Mike Percy has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster ......................................................................
Patch Set 1: (10 comments) > I think it'd also be nice to rename MiniTabletServer and > MiniMaster, though I'm happy to see that done in a separate patch. Hmm yeah I'd rather do that later on down the road, since it would likely involve renaming accessor methods and stuff too. http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/create-table-stress-test.cc File src/kudu/integration-tests/create-table-stress-test.cc: Line 30: #include "kudu/master/master.proxy.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: PS1, Line 134: InternalMiniCluster > too broad renaming? Done http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/internal_mini_cluster-itest-base.h File src/kudu/integration-tests/internal_mini_cluster-itest-base.h: PS1, Line 18: #ifndef KUDU_INTEGRATION_TESTS_MINI_CLUSTER_ITEST_BASE_H_ : #define KUDU_INTEGRATION_TESTS_MINI_CLUSTER_ITEST_BASE_H_ > nit: consider either updating this guards to reflect the change in the name Done PS1, Line 21: #include <gtest/gtest.h> > while you are at it, could you move it after the std headers? Done Line 50: void MiniClusterITestBase::StartCluster(int num_tablet_servers) { > warning: function 'StartCluster' defined in a header file; function definit Done http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/internal_mini_cluster.cc File src/kudu/integration-tests/internal_mini_cluster.cc: Line 50: using tserver::TabletServer; > warning: using decl 'TabletServer' is unused [misc-unused-using-decls] Done Line 250: for (auto mini_tablet_server : mini_tablet_servers_) { > warning: loop variable is copied but only used as const reference; consider Done http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: PS1, Line 18: #ifndef KUDU_INTEGRATION_TESTS_MINI_CLUSTER_H : #define KUDU_INTEGRATION_TESTS_MINI_CLUSTER_H > nit: #pragma once? Done Line 126: std::string GetMasterFsRoot(int indx) const; > warning: function 'kudu::InternalMiniCluster::GetMasterFsRoot' has a defini Done http://gerrit.cloudera.org:8080/#/c/7272/1/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: Line 193: std::shared_ptr<InternalMiniCluster> mini_cluster_; > Any idea why this is a shared_ptr? Seems like it could be a unique_ptr. Done -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd326a7a46f039e18c47b8e23ee1427ccf281be Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
