David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7272/2/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: PS2, Line 110: MiniMaster > Adar brought this up earlier; see my earlier response. It's just low ROI gr honestly the true ROI of this whole rename is somewhat questionable though I do see the consistency point. Seems to me that if we are to be consistent and went the extra mile to do so we should be so all over, it doesn't make a lot of sense have an InternalMiniCluster with a MiniMaster/MiniTabletServer that is not explicitly internal. I don't understand why we'd draw the line there as it seems like the job is unfinished (which it didn't seem before this rename). I don't mind doing it in another patch, but I do think we should do it. -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd326a7a46f039e18c47b8e23ee1427ccf281be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
