David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7272/2//COMMIT_MSG Commit Message: PS2, Line 7: Rename MiniCluster to InternalMiniCluster please explain why on the commit message http://gerrit.cloudera.org:8080/#/c/7272/2/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: Line 46: struct MiniClusterOptions { > Hmm, shoot. Let me wrap that on top of this one so I don't have to rebase a IMO it would make sense to have that change here, since it goes with this change. likely the rebase won't be too hard. PS2, Line 110: MiniMaster should rename these too right? (to master::InternalMaster or somesuch, like the external mini cluster) PS2, Line 119: MiniTabletServer same -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd326a7a46f039e18c47b8e23ee1427ccf281be Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
