Adar Dembo has posted comments on this change. Change subject: mini_tablet_server: support multiple data dirs ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/7211/6//COMMIT_MSG Commit Message: Line 7: mini_tablet_server: support multiple data dirs I think this would be better defined in MiniClusterOptions and then plumbed into both masters and tservers. MiniClusterOptions (and ExternalMiniClusterOptions) is how we typically configure our clusters; it's unusual to work with MiniTabletServer directly. PS6, Line 18: /test_dir/test_tserver_wal_dir : /test_dir/test_tserver_data_dir-0 : /test_dir/test_tserver_data_dir-1 : /test_dir/test_tserver_data_dir-2 Hmm, what do you think about: /test_dir/test_tserver/wal /test_dir/test_tserver/data0 /test_dir/test_tserver/data1 /test_dir/test_tserver/data2 It's a little shorter, and it retains the property that fs_root itself exists as a directory, which can be useful (e.g. compute disk space usage recursively from fs_root). http://gerrit.cloudera.org:8080/#/c/7211/6/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 59: std::vector<string> fs_data_dirs; Don't need std:: prefix. PS6, Line 60: uint32_t int here http://gerrit.cloudera.org:8080/#/c/7211/6/src/kudu/tserver/mini_tablet_server.h File src/kudu/tserver/mini_tablet_server.h: PS6, Line 43: uint32_t An int would be fine here too. -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
