Adar Dembo has posted comments on this change. Change subject: mini_cluster: support multiple data dirs ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7211/7/src/kudu/integration-tests/internal_mini_cluster.h File src/kudu/integration-tests/internal_mini_cluster.h: Line 201: const int num_data_dirs_; Hmm, doesn't seem like we need this (or fs_root_) since we have a copy of opts in opts_. http://gerrit.cloudera.org:8080/#/c/7211/7/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 110: Not your fault, but could you make 'opts' a class member and set it up in the constructor, so it's more like MiniTabletServer? Doing so would open the door to a common MiniServer implementation whose constructor can initialize ServerBaseOptions for both MiniMaster and MiniTabletServer. -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
