Mike Percy has posted comments on this change. Change subject: mini_tablet_server: support multiple data dirs ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7211/6//COMMIT_MSG Commit Message: Line 7: mini_tablet_server: support multiple data dirs > I think this would be better defined in MiniClusterOptions and then plumbed Agreed PS6, Line 18: /test_dir/test_tserver_wal_dir : /test_dir/test_tserver_data_dir-0 : /test_dir/test_tserver_data_dir-1 : /test_dir/test_tserver_data_dir-2 > Hmm, what do you think about: +1 on this http://gerrit.cloudera.org:8080/#/c/7211/6/src/kudu/tserver/tablet_server-test-base.h File src/kudu/tserver/tablet_server-test-base.h: PS6, Line 100: = 1 Don't use default arguments with virtual functions. They don't really work. -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
