Jean-Daniel Cryans has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7336/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: Line 75: final int DEFAULT_NUM_TABLET_SERVERS = 3; Seems weird to have those final ints in here, I'd just directly plug the values in doSetup. http://gerrit.cloudera.org:8080/#/c/7336/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: Line 117: final int timeoutMs = getDefaultTimeoutMs(); Curious why you're taking this out of the loop and making it final. -- To view, visit http://gerrit.cloudera.org:8080/7336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id283bcb6a6d109839d86932cb807a1da8156f6eb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
