Alexey Serbin has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7336/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: Line 96: } > I don't really understand how this change is related, why change all the ca I wanted to keep things consistent in the following sense: 1. Allow setting the default timeout parameter by doSetup() along with number of masters and tablet servers. 2. Allow BaseKuduTest's sub-classes to access the value of DEFAULT_TIMEOUT 3. Don't allow BaseKuduTest's sub-classes to update the value of DEFAULT_TIMEOUT once it set via doSetup() method. http://gerrit.cloudera.org:8080/#/c/7336/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: Line 117: final int timeoutMs = getDefaultTimeoutMs(); > It's not necessary to make it final. Yes, it's not. Does it hurt to make it final? Or there is some style convention regarding that? -- To view, visit http://gerrit.cloudera.org:8080/7336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id283bcb6a6d109839d86932cb807a1da8156f6eb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
