Alexey Serbin has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method ......................................................................
Patch Set 4: > lgtm. this would have been a little easier to review if the change > to DEFAULT_TIMEOUT had been a separate commit from the thing that's > mentioned in the header of the commit message, since that caused > changes to a bunch of different spots vs the more localized change > described here. (maybe I missed why the two are linked) Thank you for the review. Yes, those changes are linked: I wanted to keep things consistent and since DEFAULT_TIMEOUT might be set using the newly introduced doSetup() method, I wanted to: 1. Allow setting it by doSetup() along with number of masters and tablet servers. 2. Allow BaseKuduTest's sub-classes to access the value of DEFAULT_TIMEOUT. 3. Don't allow BaseKuduTest's sub-classes to update the value of DEFAULT_TIMEOUT once it set via doSetup() method. -- To view, visit http://gerrit.cloudera.org:8080/7336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id283bcb6a6d109839d86932cb807a1da8156f6eb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
