Alexey Serbin has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7336/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: Line 117: final int timeoutMs = getDefaultTimeoutMs(); > I don't think there's a convention, but typically the only final variables Oh, I see. Yep, it seems 'final' is not useful in most cases with non-primitive types (it's not like 'const' in C++ anyway). OK, I'll stop marking those 'final' since there is some other context around. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/7336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id283bcb6a6d109839d86932cb807a1da8156f6eb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
