Sam Okrent has posted comments on this change. Change subject: Add json builder utility ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7387/1//COMMIT_MSG Commit Message: PS1, Line 10: It is intended solely : for building json objects, not writing/parsing. > How, if at all, is the EasyJson class meant to interact with JsonReader and Not at all http://gerrit.cloudera.org:8080/#/c/7387/1/src/kudu/util/jsonbuilder.h File src/kudu/util/jsonbuilder.h: PS1, Line 93: oped_refptr<EasyJsonAllocator> > Is this needed? The documentation for the RefCounted class recommends making the destructor private and adding RefCounted as a friend class. Is that what you mean? -- To view, visit http://gerrit.cloudera.org:8080/7387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie195b06c5ba67af3043d2032c56b90c1a85f641a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
