Sam Okrent has posted comments on this change. Change subject: Add json builder utility ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7387/3/src/kudu/util/easy_json.h File src/kudu/util/easy_json.h: Line 62: // EasyJson associated with key is created. > not quite sure how to use these Done PS3, Line 53: // Returns the child EasyJson associated with key. : // : // Note: this method can mutate the EasyJson object : // as follows: : // : // If this EasyJson's underlying Value is not an object : // (i.e. !this->value().IsObject()), then its Value is : // coerced to an object, overwriting the old Value. : // If the given key does not exist, a Null-valued : // EasyJson associated with key is created. : EasyJson Get(const std::string& key); : : // Returns the child EasyJson at index. : // : // Note: this method can mutate the EasyJson object : // as follows: : // : // If this EasyJson's underlying Value is not an array : // (i.e. !this->value().IsArray( > need docs on all these methods Done -- To view, visit http://gerrit.cloudera.org:8080/7387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie195b06c5ba67af3043d2032c56b90c1a85f641a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
