Dan Burkert has posted comments on this change. Change subject: Add json builder utility ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7387/3/src/kudu/util/easy_json-test.cc File src/kudu/util/easy_json-test.cc: PS3, Line 92: : child["child_attr"] = 1; : ASSERT_EQ(child.value()["child_attr"].GetInt(), 1); > weird, I thought the point of the allocator thing was so that all descenden I initially suggested something like holding an owned root with sub-objects that refer/point back to the root, but I think the way it's implemented now is pretty nice (smaller API surface area than separate root/ref), and safer. Compared to the overhead of allocating the JSON objects to begin with, I don't think the reference counting will show up, perf wise. -- To view, visit http://gerrit.cloudera.org:8080/7387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie195b06c5ba67af3043d2032c56b90c1a85f641a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
