Andrew Wong has posted comments on this change. Change subject: mini_cluster: support multiple data dirs ......................................................................
Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/7211/15/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 84: RETURN_NOT_OK(env_util::CreateDirIfMissing(Env::Default(), fs_root_)); > It seems counterintuitive that we implicitly treat opts_.fs_opts.wal_path a Hrm, for multiple wal dirs, I'd think that they'd still fall within a single minimaster root, but I agree it feels weird getting the root this way. Done PS15, Line 85: ); > nit: indentation and also you can leave this bool out if you don't use it ( Done http://gerrit.cloudera.org:8080/#/c/7211/15/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 82: RETURN_NOT_OK(env_util::CreateDirIfMissing(Env::Default(), fs_root_)); > Seems better to have an fs_root_ member here than piggyback on wal_path as Done Line 83: unique_ptr<TabletServer> server(new TabletServer(opts_)); > nit: bool is optional Done -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
