Andrew Wong has posted comments on this change. Change subject: mini_cluster: support multiple data dirs ......................................................................
Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/7211/16/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 46: MiniMaster::MiniMaster(string fs_root, HostPort rpc_bind_addr, int num_data_dirs) > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/7211/16/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 50: MiniTabletServer::MiniTabletServer(string fs_root, > warning: pass by value and use std::move [modernize-pass-by-value] Done -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
