Mike Percy has posted comments on this change. Change subject: mini_cluster: support multiple data dirs ......................................................................
Patch Set 15: Code-Review+1 (4 comments) Looks good, just a couple nits http://gerrit.cloudera.org:8080/#/c/7211/15/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 84: RETURN_NOT_OK(env_util::CreateDirIfMissing(Env::Default(), DirName(opts_.fs_opts.wal_path), It seems counterintuitive that we implicitly treat opts_.fs_opts.wal_path as the fs_root dir. I think we should keep fs_root_ as a member. This will also matter once we add support for multiple wal dirs so better to just leave it as it was now. PS15, Line 85: &created nit: indentation and also you can leave this bool out if you don't use it (it defaults to nullptr) http://gerrit.cloudera.org:8080/#/c/7211/15/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 82: RETURN_NOT_OK(env_util::CreateDirIfMissing(Env::Default(), DirName(opts_.fs_opts.wal_path), Seems better to have an fs_root_ member here than piggyback on wal_path as noted in the other file Line 83: &created)); nit: bool is optional -- To view, visit http://gerrit.cloudera.org:8080/7211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c9352f1a3565d58149cf2c63d37246c6b39c23 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
