Sam Okrent has posted comments on this change. Change subject: Add json builder utility ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7387/4/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 147: init.cc > maintain alphabetical sort order Done Line 355: ADD_KUDU_TEST(jsonreader-test) > Maintain alphabetical sort order Done http://gerrit.cloudera.org:8080/#/c/7387/4/src/kudu/util/easy_json-test.cc File src/kudu/util/easy_json-test.cc: Line 78: for (int i = 0; i < 2; i++ ) { > Add braces Done -- To view, visit http://gerrit.cloudera.org:8080/7387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie195b06c5ba67af3043d2032c56b90c1a85f641a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
