Sandish Kumar HN has posted comments on this change. Change subject: kudu-spark-tools: Spark tool for Import & Export different format of files such as parquet,avro,csv in and to from kudu tables kudu-client-tools: mapreduced base export to csv and import parquet files. ......................................................................
Patch Set 2: (3 comments) Thanks for reviewing. Few Q7A's http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java File java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java: Line 114: default: > Missing UNIXTIME_MICROS? is UNIXTIME_MICROS is LONG type?? http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java File java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java: Line 88: FileInputFormat.setInputPaths(job, inputDir); > You could run some pre-flight checks like making sure that the columns matc you want me to read column names from Kudu table and check with input parquet schema? http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java File java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java: Line 101: case DOUBLE: > UNIXTIME_MICROS would be recognized but not supported, someone might have T If My understanding is correct. we should identify TIMESTAMP in the input parquet file and warn the users saying that it's not supported? please correct me if I'm wrong. should we do this in Map phase or Driver phase?? -- To view, visit http://gerrit.cloudera.org:8080/7421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sandish Kumar HN <sanysand...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sandish Kumar HN <sanysand...@gmail.com> Gerrit-HasComments: Yes
