Jean-Daniel Cryans has posted comments on this change.

Change subject: kudu-spark-tools: Spark tool for Import & Export different 
format of files such as parquet,avro,csv in and to from kudu tables 
kudu-client-tools: mapreduced base export to csv and import parquet files.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java
File 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ExportCsvMapper.java:

Line 114:         default:
> is UNIXTIME_MICROS is LONG type??
It is.


http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
File 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java:

Line 88:     FileInputFormat.setInputPaths(job, inputDir);
> you want me to read column names from Kudu table and check with input parqu
Yes, this way the job won't start if some things just don't match.


http://gerrit.cloudera.org:8080/#/c/7421/2/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java
File 
java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquetMapper.java:

Line 101:           case DOUBLE:
> If My understanding is correct. we should identify TIMESTAMP in the input p
I'd recommend in the Driver as part of checking the schema.


-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN <[email protected]>
Gerrit-HasComments: Yes

Reply via email to