Sandish Kumar HN has posted comments on this change. Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro) ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7421/3/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java File java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java: Line 101: System.exit(0); > Having System.exits in the code isn't good, ideally this case would be test what should I use instead of system.exit(0). just LOG.error("") enough?? http://gerrit.cloudera.org:8080/#/c/7421/3/java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java File java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java: Line 50: public class ITImportParquet extends BaseKuduTest { > I'd suggest having a separate test that specifically verifies the pre-fligh separate test-case for pre-flight checks? and what should be the expected result ?? -- To view, visit http://gerrit.cloudera.org:8080/7421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-HasComments: Yes
