Hao Hao has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/7374/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS5, Line 266: > docs for this This change has been removed. PS5, Line 357: // Updates internal bookkeeping state to reflect the creation of a block, : // marking this container as full if needed. Should only be called when a : // block is fully written, as it will round up the container data file's position. : // : // This function is thread unsafe. : void BlockCreated(const scoped_refptr<LogBlock>& block); : : // Updates internal bookkeeping state to reflect the > seems like comments here should be updated Same as above. PS5, Line 761: g > Will we need to be updated when disk failure handling gets in? If so, maybe It appears to me that here is to handle whatever is not handled in the disk failure handling? so it should be ok to not update anything here later when disk failure handling gets in. -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
