Adar Dembo has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'non-writable' after IOError ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7374/7/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 1000: if (s.ok()) { > CreateBlock calls above are injecting failures (the 0.1 param). Ah, I thought it was a straight-up move of create_a_block. I think it's rather unusual for a helper function to temporarily set a flag, then unset it. Perhaps leave create_a_block unmodified and duplicate it inline here? -- To view, visit http://gerrit.cloudera.org:8080/7374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15062b9d82c9cb563fb6bb2af7ec89da5f71e28f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
